fix(Icons): prevent icons from having same IDs (duplicate-id violation) #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we removed the original timestamp with the reset.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a4a2791:
|
dinarosv
approved these changes
Nov 10, 2022
✅ DNB Eufemia Portal deploy preview ready
|
tujoworker
pushed a commit
that referenced
this pull request
Nov 17, 2022
# [9.38.0-beta.1](v9.37.0...v9.38.0-beta.1) (2022-11-17) ### Bug Fixes * add support to IS_SAFARI_DESKTOP for Safari v16 on macOS ([#1718](#1718)) ([54e2cba](54e2cba)) * **Anchor:** export types as AnchorAllProps and original instance ([#1715](#1715)) ([92ec784](92ec784)) * **Icons:** prevent icons from having same IDs (duplicate-id violation) ([#1714](#1714)) ([5e4079d](5e4079d)) * **Provider:** rewrite to functional component ([#1731](#1731)) ([b504d06](b504d06)) * **Table:** align odd/even modifiers with CSS nth ([#1724](#1724)) ([8bdad07](8bdad07)) ### Features * **Table:** add "fixed" prop for fixed table layouts ([#1708](#1708)) ([241ee0f](241ee0f)) * **Table:** add Table.SortButton ([#1709](#1709)) ([288a8db](288a8db)) * **Table:** add Th.HelpButton to be used in Table Headers ([#1711](#1711)) ([c142323](c142323)) * **Th:** add table header sortable props ([#1706](#1706)) ([c40393a](c40393a)) * **Tr:** automate odd/even and make it overridable ([#1705](#1705)) ([d73d3cb](d73d3cb)) * **Upload:** support files dropped on the document body ([#1719](#1719)) ([f206243](f206243))
|
🎉 This PR is included in version 9.38.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tujoworker
pushed a commit
that referenced
this pull request
Nov 22, 2022
# [9.38.0](v9.37.0...v9.38.0) (2022-11-22) ### Bug Fixes * add support to IS_SAFARI_DESKTOP for Safari v16 on macOS ([#1718](#1718)) ([54e2cba](54e2cba)) * **Anchor:** export types as AnchorAllProps and original instance ([#1715](#1715)) ([92ec784](92ec784)) * **Icons:** prevent icons from having same IDs (duplicate-id violation) ([#1714](#1714)) ([5e4079d](5e4079d)) * **Provider:** rewrite to functional component ([#1731](#1731)) ([b504d06](b504d06)) * **Table:** align odd/even modifiers with CSS nth ([#1724](#1724)) ([8bdad07](8bdad07)) ### Features * **Table:** add "fixed" prop for fixed table layouts ([#1708](#1708)) ([241ee0f](241ee0f)) * **Table:** add table "border" and "outline" property ([#1739](#1739)) ([ad63ffb](ad63ffb)) * **Table:** add Table.ScrolView to support horizontal scroll ([#1735](#1735)) ([85a4d86](85a4d86)) * **Table:** add Table.SortButton ([#1709](#1709)) ([288a8db](288a8db)) * **Table:** add TableContainer to stack tables with an outline ([#1740](#1740)) ([376ac06](376ac06)) * **Table:** add Th.HelpButton to be used in Table Headers ([#1711](#1711)) ([c142323](c142323)) * **Table:** support rowSpan ([#1733](#1733)) ([463692d](463692d)) * **Th:** add table header sortable props ([#1706](#1706)) ([c40393a](c40393a)) * **Tr:** automate odd/even and make it overridable ([#1705](#1705)) ([d73d3cb](d73d3cb)) * **Typography:** support styles for superscript and subscript elements ([#1721](#1721)) ([c2b043d](c2b043d)) * **Upload:** support files dropped on the document body ([#1719](#1719)) ([f206243](f206243))
|
🎉 This PR is included in version 9.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Just so y'all know, Figma exports
In the majority of cases, you don't need to clip any content. So if you uncheck it, there are no visual changes, but the exported SVG doesn't have this
|
joakbjerk
pushed a commit
that referenced
this pull request
Mar 27, 2023
…n) (#1714) * fix(Icons): prevent icons from having same IDs (duplicate-id violation) * Refetch icons with the command: `yarn figma:reset` * Update snapshots with new order Because we removed the original timestamp with the reset.
|
thanks for pointing out @buzinas ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for @dinarosv for reporting 🙏
After the change, SVG IDs get the file-name, so they will be unique per icon. But not per page. So that's still an issue. And can lower a lighthouse score, still.
IDs in SVGs are used in order to link the usage of
clipPath.Its the Figma export that sets this. 52 icons are effected (from a total of 260).
E.g. the
thumb_up(16px) uses this, but notthumb_up(24px) – I'm not sure why this difference. We may try to find out more about it.Approaches we can do to enhance this beyond this PR:
clipPathon some icons, and sddenly not on very similar icons.clipPath. What are the side-effects? They can be different from icon to icon.clipPathusage. But that's not so easy. There is an open issue/request for it.In this PR, we get this change: