feat(Dialog): add new variant confirm #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b6e1a03:
|
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 9m PerformanceLighthouse report
|
dinarosv
force-pushed
the
feat/dialog-confirm
branch
4 times, most recently
from
0fce1d7 to
91a2d27
Compare
tujoworker
force-pushed
the
feat/dialog-confirm
branch
from
91a2d27 to
4575c97
Compare
dinarosv
force-pushed
the
feat/dialog-confirm
branch
from
4575c97 to
4debf44
Compare
tujoworker
approved these changes
Feb 23, 2022
Think we should do that. There were also a few other things I will add, that we talked about, before I merge :) |
tujoworker
approved these changes
Feb 23, 2022
packages/dnb-design-system-portal/src/docs/uilib/components/dialog/prop-table.md
Outdated
Show resolved
Hide resolved
dinarosv
force-pushed
the
feat/dialog-confirm
branch
2 times, most recently
from
a287c58 to
38891ca
Compare
tujoworker
approved these changes
Feb 24, 2022
packages/dnb-eufemia/src/components/dialog/parts/DialogAction.tsx
Outdated
Show resolved
Hide resolved
dinarosv
force-pushed
the
feat/dialog-confirm
branch
from
921293d to
93b6aae
Compare
- added a generic demo
Co-authored-by: Tobias Høegh <[email protected]>
dinarosv
force-pushed
the
feat/dialog-confirm
branch
from
93b6aae to
b6e1a03
Compare
tujoworker
pushed a commit
that referenced
this pull request
Mar 2, 2022
# [9.24.0](v9.23.1...v9.24.0) (2022-03-02) ### Bug Fixes * **Dialog:** set role alertdialog for confirmation variant ([8ec99af](8ec99af)) * **Dropdown:** fix empty data entry handling ([4e4762b](4e4762b)) ### Features * **Avatar:** add hasLabel to omit group warning ([#1318](#1318)) ([ed43481](ed43481)) * **Dialog:** add new variant confirmation ([#1302](#1302)) ([bdb7bb4](bdb7bb4)) * **FormStatus:** add new marketing state/status ([#1317](#1317)) ([f5e63a9](f5e63a9)) * **NumberFormat:** add "compact" property – format a number compact with an abbreviation ([0e26449](0e26449)) * **Tag:** omit non-existing group warning with new prop: hasLabel ([079cdcd](079cdcd))
|
🎉 This PR is included in version 9.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added variant
confirmto Dialog.See the Figma file for the different variant design.