fix: button aria-label fix, to make it more flexible

dnbexperience · Jan 31, 2019 · f75d9dc · f75d9dc
1 parent 24f3cc3
commit f75d9dc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/dnb-ui-lib/src/components/button/Button.js b/packages/dnb-ui-lib/src/components/button/Button.js
@@ -194,13 +194,15 @@ export default class Button extends PureComponent {
       className: classes,
       type,
       title: title || text,
-      ['aria-label']: title || text,
       id,
       disabled,
       onMouseOut: this.onMouseOutHandler, // for resetting the button to the default state
       onClick: this.onClickHandler,
       ...props
     }
+    if (!params['aria-label'] && !text && title) {
+      params['aria-label'] = title
+    }
 
     // also used for code markup simulation
     validateDOMAttributes(this.props, params)

diff --git a/packages/dnb-ui-lib/src/components/button/__tests__/__snapshots__/Button.test.js.snap b/packages/dnb-ui-lib/src/components/button/__tests__/__snapshots__/Button.test.js.snap
@@ -22,7 +22,6 @@ exports[`Button component have to match default button snapshot 1`] = `
   variant="primary"
 >
   <button
-    aria-label="This is a button title"
     className="dnb-button dnb-button--primary dnb-button--icon-position-right dnb-button--has-text dnb-button--has-icon id class className"
     disabled="disabled"
     id="id"
@@ -123,7 +122,6 @@ exports[`Button component have to match href="..." snapshot 1`] = `
   variant="primary"
 >
   <a
-    aria-label="This is a button title"
     className="dnb-button dnb-button--primary dnb-button--icon-position-right dnb-button--has-text dnb-button--has-icon id class className dnb-no-anchor-underline dnb-no-anchor-hover"
     disabled="disabled"
     href="https://url"