fix: add title prop to #date-picker

dnbexperience · Aug 12, 2019 · 74da4ba · 74da4ba
1 parent bf657bc
commit 74da4ba
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/packages/dnb-ui-lib/src/components/date-picker/DatePicker.js b/packages/dnb-ui-lib/src/components/date-picker/DatePicker.js
@@ -43,6 +43,7 @@ const renderProps = {
 
 export const propTypes = {
   id: PropTypes.string,
+  title: PropTypes.string,
   date: PropTypes.oneOfType([
     PropTypes.instanceOf(Date),
     PropTypes.string
@@ -134,6 +135,7 @@ export const propTypes = {
 
 export const defaultProps = {
   id: null,
+  title: null,
   date: null,
   start_date: null,
   end_date: null,
@@ -547,6 +549,7 @@ export default class DatePicker extends PureComponent {
 
     const {
       label,
+      title,
       label_direction,
       only_month,
       hide_navigation_buttons,
@@ -661,6 +664,7 @@ export default class DatePicker extends PureComponent {
           <span className="dnb-date-picker__shell">
             <DatePickerInput
               id={id}
+              title={title}
               disabled={isTrue(disabled)}
               maskOrder={mask_order}
               maskPlaceholder={mask_placeholder}

diff --git a/packages/dnb-ui-lib/src/components/date-picker/DatePickerInput.js b/packages/dnb-ui-lib/src/components/date-picker/DatePickerInput.js
@@ -25,6 +25,7 @@ import { isDisabled } from './DatePickerCalc'
 
 export const propTypes = {
   id: PropTypes.string,
+  title: PropTypes.string,
   maskOrder: PropTypes.string,
   maskPlaceholder: PropTypes.string,
   separatorRexExp: PropTypes.instanceOf(RegExp),
@@ -50,6 +51,7 @@ export const propTypes = {
 
 export const defaultProps = {
   id: null,
+  title: null,
   maskOrder: 'dd/mm/yyyy',
   maskPlaceholder: 'dd/mm/åååå',
   separatorRexExp: /[-/ ]/g,
@@ -496,6 +498,7 @@ export default class DatePickerInput extends PureComponent {
   render() {
     const {
       id,
+      title,
 
       submitAttributes,
       range /* eslint-disable-line */,
@@ -540,7 +543,7 @@ export default class DatePickerInput extends PureComponent {
             id={id}
             disabled={disabled}
             className={opened ? 'dnb-button--active' : null}
-            // title={submit_button_title} // Not implemented yet
+            title={title}
             type="button"
             icon="calendar"
             variant="secondary"

diff --git a/...ges/dnb-ui-lib/src/components/date-picker/__tests__/__snapshots__/DatePicker.test.js.snap b/...ges/dnb-ui-lib/src/components/date-picker/__tests__/__snapshots__/DatePicker.test.js.snap
@@ -77,6 +77,7 @@ exports[`DatePicker component have to match snapshot 1`] = `
   status_state="error"
   submit_button_text="Ok"
   sync={true}
+  title={null}
 >
   <span
     className="dnb-date-picker dnb-date-picker__status--error dnb-date-picker--hidden dnb-date-picker--show-input dnb-date-picker--show-footer"
@@ -119,6 +120,7 @@ exports[`DatePicker component have to match snapshot 1`] = `
               "aria-expanded": false,
             }
           }
+          title={null}
         >
           <Input
             align={null}

diff --git a/packages/dnb-ui-lib/stories/components/DatePicker.js b/packages/dnb-ui-lib/stories/components/DatePicker.js
@@ -21,6 +21,7 @@ export default [
             label="Date Picker 1:"
             right="small"
             date="1981-01-15"
+            title="My Button"
           />
           <DatePicker
             label="Date Picker 2:"