fix: button styling on hover

dnbexperience · Jan 21, 2019 · 7455c34 · 7455c34
1 parent 619e8f9
commit 7455c34
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/packages/dnb-ui-lib/src/components/button/__tests__/__snapshots__/Button.test.js.snap b/packages/dnb-ui-lib/src/components/button/__tests__/__snapshots__/Button.test.js.snap
@@ -287,7 +287,7 @@ exports[`Button scss have to match default theme snapshot 1`] = `
     color: var(--color-sea-green);
     background-color: var(--color-mint-green-50);
     border-color: var(--color-mint-green-50);
-    box-shadow: 0 0 0 0 0 0 var(--button-border-width--hover) var(--color-mint-green-50); }
+    box-shadow: 0 0 0 var(--button-border-width--hover) var(--color-mint-green-50); }
     .no-touch .dnb-button--primary:hover:not([disabled]):not([disabled]):active {
       box-shadow: 0 0 0 2px transparent;
       border-color: transparent; }
@@ -313,7 +313,7 @@ exports[`Button scss have to match default theme snapshot 1`] = `
     color: var(--color-sea-green);
     background-color: var(--color-mint-green-50);
     border-color: var(--color-mint-green-50);
-    box-shadow: 0 0 0 0 0 0 var(--button-border-width--hover) var(--color-mint-green-50); }
+    box-shadow: 0 0 0 var(--button-border-width--hover) var(--color-mint-green-50); }
     .no-touch .dnb-button--secondary:hover:not([disabled]):not([disabled]):active {
       box-shadow: 0 0 0 2px transparent;
       border-color: transparent; }

diff --git a/packages/dnb-ui-lib/src/components/button/style/_button-mixins.scss b/packages/dnb-ui-lib/src/components/button/style/_button-mixins.scss
@@ -12,10 +12,7 @@
     background-color: $background-color;
     border-color: $background-color;
 
-    @include fakeBorder(
-      null,
-      0 0 0 var(--button-border-width--hover) $background-color
-    );
+    box-shadow: 0 0 0 var(--button-border-width--hover) $background-color;
 
     &:not([disabled]):active {
       @include fakeBorder(transparent);