fix: do not declare aria-hidden=true inside of components

dnbexperience · May 27, 2019 · 5647bf4 · 5647bf4
1 parent 8a27802
commit 5647bf4
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 11 deletions.
diff --git a/packages/dnb-ui-lib/src/components/checkbox/Checkbox.js b/packages/dnb-ui-lib/src/components/checkbox/Checkbox.js
@@ -215,7 +215,6 @@ export default class Checkbox extends Component {
           <FormLabel
             id={id + '-label'}
             for_id={id}
-            aria-hidden
             text={label}
             disabled={disabled}
           />

diff --git a/packages/dnb-ui-lib/src/components/checkbox/__tests__/__snapshots__/Checkbox.test.js.snap b/packages/dnb-ui-lib/src/components/checkbox/__tests__/__snapshots__/Checkbox.test.js.snap
@@ -22,7 +22,6 @@ exports[`Checkbox component have to match snapshot 1`] = `
   value="value"
 >
   <FormLabel
-    aria-hidden={true}
     class={null}
     className={null}
     disabled="disabled"

diff --git a/packages/dnb-ui-lib/src/components/dropdown/Dropdown.js b/packages/dnb-ui-lib/src/components/dropdown/Dropdown.js
@@ -683,12 +683,7 @@ export default class Dropdown extends Component {
     return (
       <>
         {label && (
-          <FormLabel
-            aria-hidden
-            for_id={id}
-            text={label}
-            disabled={disabled}
-          />
+          <FormLabel for_id={id} text={label} disabled={disabled} />
         )}
         <span className={classes} ref={this._ref}>
           <span className="dnb-dropdown__shell">

diff --git a/packages/dnb-ui-lib/src/components/dropdown/__tests__/__snapshots__/Dropdown.test.js.snap b/packages/dnb-ui-lib/src/components/dropdown/__tests__/__snapshots__/Dropdown.test.js.snap
@@ -61,7 +61,6 @@ exports[`Dropdown component have to match snapshot 1`] = `
   title="title"
 >
   <FormLabel
-    aria-hidden={true}
     class={null}
     className={null}
     disabled="disabled"

diff --git a/packages/dnb-ui-lib/src/components/radio/__tests__/__snapshots__/Radio.test.js.snap b/packages/dnb-ui-lib/src/components/radio/__tests__/__snapshots__/Radio.test.js.snap
@@ -38,6 +38,7 @@ exports[`Radio component have to match snapshot 1`] = `
     >
       <label
         aria-disabled={true}
+        aria-hidden={true}
         className="dnb-form-label"
         disabled="disabled"
         htmlFor="id"

diff --git a/packages/dnb-ui-lib/src/components/switch/Switch.js b/packages/dnb-ui-lib/src/components/switch/Switch.js
@@ -215,7 +215,6 @@ export default class Switch extends Component {
           <FormLabel
             id={id + '-label'}
             for_id={id}
-            aria-hidden
             text={label}
             disabled={disabled}
           />

diff --git a/packages/dnb-ui-lib/src/components/switch/__tests__/__snapshots__/Switch.test.js.snap b/packages/dnb-ui-lib/src/components/switch/__tests__/__snapshots__/Switch.test.js.snap
@@ -22,7 +22,6 @@ exports[`Switch component have to match snapshot 1`] = `
   value="value"
 >
   <FormLabel
-    aria-hidden={true}
     class={null}
     className={null}
     disabled="disabled"