fix: use asterisk to make number feature working everywhere on firefox

dnbexperience · May 2, 2019 · 3b1c194 · 3b1c194
1 parent abd26cc
commit 3b1c194
Show file tree

Hide file tree

Showing 14 changed files with 79 additions and 51 deletions.
diff --git a/packages/dnb-ui-lib/src/components/button/__tests__/__snapshots__/Button.test.js.snap b/packages/dnb-ui-lib/src/components/button/__tests__/__snapshots__/Button.test.js.snap
@@ -482,8 +482,6 @@ exports[`Button scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -494,6 +492,9 @@ exports[`Button scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-button * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-button *,
   .dnb-button ::before,
   .dnb-button ::after {

diff --git a/packages/dnb-ui-lib/src/components/dropdown/__tests__/__snapshots__/Dropdown.test.js.snap b/packages/dnb-ui-lib/src/components/dropdown/__tests__/__snapshots__/Dropdown.test.js.snap
@@ -441,8 +441,6 @@ exports[`Dropdown scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -453,6 +451,9 @@ exports[`Dropdown scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-form-label * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-form-label *,
   .dnb-form-label ::before,
   .dnb-form-label ::after {
@@ -500,8 +501,6 @@ exports[`Dropdown scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -512,6 +511,9 @@ exports[`Dropdown scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-form-status * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-form-status *,
   .dnb-form-status ::before,
   .dnb-form-status ::after {
@@ -580,8 +582,6 @@ exports[`Dropdown scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -592,6 +592,9 @@ exports[`Dropdown scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-dropdown * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-dropdown *,
   .dnb-dropdown ::before,
   .dnb-dropdown ::after {

diff --git a/packages/dnb-ui-lib/src/components/form-label/__tests__/__snapshots__/FormLabel.test.js.snap b/packages/dnb-ui-lib/src/components/form-label/__tests__/__snapshots__/FormLabel.test.js.snap
@@ -63,8 +63,6 @@ exports[`FormLabel scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -75,6 +73,9 @@ exports[`FormLabel scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-form-label * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-form-label *,
   .dnb-form-label ::before,
   .dnb-form-label ::after {

diff --git a/...ges/dnb-ui-lib/src/components/form-status/__tests__/__snapshots__/FormStatus.test.js.snap b/...ges/dnb-ui-lib/src/components/form-status/__tests__/__snapshots__/FormStatus.test.js.snap
@@ -112,8 +112,6 @@ exports[`FormStatus scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -124,6 +122,9 @@ exports[`FormStatus scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-form-status * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-form-status *,
   .dnb-form-status ::before,
   .dnb-form-status ::after {

diff --git a/...s/dnb-ui-lib/src/components/input-masked/__tests__/__snapshots__/InputMasked.test.js.snap b/...s/dnb-ui-lib/src/components/input-masked/__tests__/__snapshots__/InputMasked.test.js.snap
@@ -199,8 +199,6 @@ exports[`InputMasked scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -211,6 +209,9 @@ exports[`InputMasked scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-button * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-button *,
   .dnb-button ::before,
   .dnb-button ::after {
@@ -414,8 +415,6 @@ a.dnb-button:active, a.dnb-button:focus {
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -426,6 +425,9 @@ a.dnb-button:active, a.dnb-button:focus {
   */
   margin: 0;
   padding: 0; }
+  .dnb-form-label * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-form-label *,
   .dnb-form-label ::before,
   .dnb-form-label ::after {
@@ -473,8 +475,6 @@ a.dnb-button:active, a.dnb-button:focus {
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -485,6 +485,9 @@ a.dnb-button:active, a.dnb-button:focus {
   */
   margin: 0;
   padding: 0; }
+  .dnb-form-status * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-form-status *,
   .dnb-form-status ::before,
   .dnb-form-status ::after {
@@ -553,8 +556,6 @@ a.dnb-button:active, a.dnb-button:focus {
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -565,6 +566,9 @@ a.dnb-button:active, a.dnb-button:focus {
   */
   margin: 0;
   padding: 0; }
+  .dnb-input * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-input *,
   .dnb-input ::before,
   .dnb-input ::after {
@@ -685,8 +689,6 @@ a.dnb-button:active, a.dnb-button:focus {
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -697,6 +699,9 @@ a.dnb-button:active, a.dnb-button:focus {
   */
   margin: 0;
   padding: 0; }
+  .dnb-input-masked * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-input-masked *,
   .dnb-input-masked ::before,
   .dnb-input-masked ::after {

diff --git a/packages/dnb-ui-lib/src/components/input/__tests__/__snapshots__/Input.test.js.snap b/packages/dnb-ui-lib/src/components/input/__tests__/__snapshots__/Input.test.js.snap
@@ -524,8 +524,6 @@ exports[`Input scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -536,6 +534,9 @@ exports[`Input scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-button * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-button *,
   .dnb-button ::before,
   .dnb-button ::after {
@@ -739,8 +740,6 @@ a.dnb-button:active, a.dnb-button:focus {
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -751,6 +750,9 @@ a.dnb-button:active, a.dnb-button:focus {
   */
   margin: 0;
   padding: 0; }
+  .dnb-form-label * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-form-label *,
   .dnb-form-label ::before,
   .dnb-form-label ::after {
@@ -798,8 +800,6 @@ a.dnb-button:active, a.dnb-button:focus {
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -810,6 +810,9 @@ a.dnb-button:active, a.dnb-button:focus {
   */
   margin: 0;
   padding: 0; }
+  .dnb-form-status * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-form-status *,
   .dnb-form-status ::before,
   .dnb-form-status ::after {
@@ -878,8 +881,6 @@ a.dnb-button:active, a.dnb-button:focus {
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -890,6 +891,9 @@ a.dnb-button:active, a.dnb-button:focus {
   */
   margin: 0;
   padding: 0; }
+  .dnb-input * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-input *,
   .dnb-input ::before,
   .dnb-input ::after {

diff --git a/packages/dnb-ui-lib/src/components/logo/__tests__/__snapshots__/Logo.test.js.snap b/packages/dnb-ui-lib/src/components/logo/__tests__/__snapshots__/Logo.test.js.snap
@@ -69,8 +69,6 @@ exports[`Logo scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -81,6 +79,9 @@ exports[`Logo scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-logo * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-logo *,
   .dnb-logo ::before,
   .dnb-logo ::after {

diff --git a/packages/dnb-ui-lib/src/components/modal/__tests__/__snapshots__/Modal.test.js.snap b/packages/dnb-ui-lib/src/components/modal/__tests__/__snapshots__/Modal.test.js.snap
@@ -575,8 +575,6 @@ exports[`Modal scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -587,6 +585,9 @@ exports[`Modal scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-button * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-button *,
   .dnb-button ::before,
   .dnb-button ::after {
@@ -786,8 +787,6 @@ a.dnb-button:active, a.dnb-button:focus {
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -798,6 +797,9 @@ a.dnb-button:active, a.dnb-button:focus {
   */
   margin: 0;
   padding: 0; }
+  .dnb-modal * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-modal *,
   .dnb-modal ::before,
   .dnb-modal ::after {

diff --git a/packages/dnb-ui-lib/src/components/slider/__tests__/__snapshots__/Slider.test.js.snap b/packages/dnb-ui-lib/src/components/slider/__tests__/__snapshots__/Slider.test.js.snap
@@ -103,8 +103,6 @@ exports[`Slider scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -115,6 +113,9 @@ exports[`Slider scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-slider * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-slider *,
   .dnb-slider ::before,
   .dnb-slider ::after {

diff --git a/...b-ui-lib/src/components/step-indicator/__tests__/__snapshots__/StepIndicator.test.js.snap b/...b-ui-lib/src/components/step-indicator/__tests__/__snapshots__/StepIndicator.test.js.snap
@@ -221,8 +221,6 @@ exports[`StepIndicator scss have to match snapshot 1`] = `
   line-height: 1.5rem;
   color: var(--color-black-80, #333);
   -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-  font-variant-numeric: lining-nums;
-  font-feature-settings: \\"lnum\\";
   /**
   * 1. Remove repeating backgrounds in all browsers (opinionated).
   * 2. Add border box sizing in all browsers (opinionated).
@@ -233,6 +231,9 @@ exports[`StepIndicator scss have to match snapshot 1`] = `
   */
   margin: 0;
   padding: 0; }
+  .dnb-step-indicator * {
+    font-variant-numeric: lining-nums;
+    font-feature-settings: \\"lnum\\"; }
   .dnb-step-indicator *,
   .dnb-step-indicator ::before,
   .dnb-step-indicator ::after {