Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add realActive() command #50

Merged
merged 6 commits into from
Apr 29, 2021
Merged

feat: add realActive() command #50

merged 6 commits into from
Apr 29, 2021

Conversation

arjunpatel17
Copy link
Contributor

Closes #49

src/commands/realActive.ts Outdated Show resolved Hide resolved
src/index.d.ts Outdated Show resolved Hide resolved
@dmtrKovalenko
Copy link
Owner

Thanks for this feature its definitely helpful, but I think more clear name will be mouseDown() and ideally we also need to add mouseUp event.

+ it's required to update readme to include new command

src/index.d.ts Outdated Show resolved Hide resolved
src/index.d.ts Outdated Show resolved Hide resolved
Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh sorry, each command should start with real prefix. e.g. cy.realMouseDown I can push this change on my own

@dmtrKovalenko dmtrKovalenko changed the title add realActive() command feat: add realActive() command Apr 29, 2021
@dmtrKovalenko dmtrKovalenko merged commit c87d392 into dmtrKovalenko:develop Apr 29, 2021
@dmtrKovalenko
Copy link
Owner

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arjunpatel17 arjunpatel17 deleted the feature/realActive branch April 29, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a .realActive() method
2 participants