realSwipe - x: 0 or y: 0 is incorrectly rejected as being treated as falsey

[amoshydra]

Expected

TouchStart and TouchEvent should start at coordinate x: 0 and y: 0 when x: 0 and y: 0 is provided in readSwipe

cy.mount(<Canvas />);

cy
  .get("body")
  .realSwipe("toRight", {
    x: 0,
    y: 0,
  })
;

Current

However when a 0 value is provided to either x or y, position is computed to be undefined as the values are falsey and intepreted as not provided.

cypress-real-events/src/commands/realSwipe.ts

Lines 101 to 104 in 8b8a509

	const position =
	options.x && options.y
	? { x: options.x, y: options.y }
	: options.touchPosition;

Reproduce:

Reproduce repository: https://github.com/amoshydra/repro-dmtrKovalenko-cypress-real-events-i-swipes/blob/real-swipe-with-x-or-y-be-0/src/components/input/Canvas.cy.tsx

The video preview shows 3 tests with the following calls:

.realSwipe("toRight", {
  x: 0,
  y: 1,
})

.realSwipe("toRight", {
  x: 1,
  y: 0,
})

.realSwipe("toRight", {
  x: 1,
  y: 1,
})

repro.mp4

Possible solution

1. Actually check if x and y are undefined or 0.
2. If either x or y is provided, automatically fill the undefined x or y as 0.
3. options.touchPosition should be used only when both x and y are undefined.

Proposal : #642

[dmtrKovalenko]

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀