Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add touchMoveDelay option to realSwipe #621

Merged
merged 2 commits into from
Feb 16, 2024
Merged

add touchMoveDelay option to realSwipe #621

merged 2 commits into from
Feb 16, 2024

Conversation

alirezamirian
Copy link
Contributor

@alirezamirian alirezamirian commented Jan 30, 2024 •
edited
Loading

closes #620

Took the liberty of fixing some unrelated minor documentation issues too.

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Jan 30, 2024

PR Summary

  • Adjustment of the Default Length in RealSwipeOptions
    The length option in the RealSwipeOptions interface, which controls the distance of swipe motion in a real swipe action, has been revised. It has been changed from a default value of 50 to 10, making swipe actions shorter by default.

  • Change in Default Step Value in RealSwipeOptions
    The step option, controlling the increments in which the swipe action occurs within the RealSwipeOptions, has been updated to a default value of 10. A smaller step size could make the swipe action appear smoother.

  • Introduction of touchMoveDelay Option to RealSwipeOptions
    A new parameter touchMoveDelay has been introduced to the RealSwipeOptions interface. With a default setting of 0, this parameter allows a delay to be implemented before a swipe action begins.

  • Introduction of Wait Function
    A new wait function has been added which creates a delay for a designated period. This enables system pauses and holds during processing, providing more flexibility in behavior control.

  • Delay Before Swipe in realSwipe Function
    In order to delay the swipe action, a check has been integrated within the realSwipe function. Here, the system waits for the specified touchMoveDelay period before initiating the swipe action.

dmtrKovalenko
dmtrKovalenko requested changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm left a few simple comments

cypress/e2e/swipe.cy.ts Outdated Show resolved Hide resolved
src/commands/realSwipe.ts Show resolved Hide resolved
@alirezamirian alirezamirian force-pushed the #620/swipe-touch-delay branch from 0058142 to 86b2240 Compare January 30, 2024 18:57
dmtrKovalenko
dmtrKovalenko approved these changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I'll take a look on the CI issue later this day and hopefully will be able to release this today

src/wait.ts Outdated Show resolved Hide resolved
@alirezamirian alirezamirian force-pushed the #620/swipe-touch-delay branch from 86b2240 to afb0254 Compare January 30, 2024 19:02
@alirezamirian
Copy link
Contributor Author

Is this waiting for the CI pipeline to pass? I had a look at the error and it seemed like an unrelated issue in running Cypress.

@dmtrKovalenko dmtrKovalenko merged commit 50f46f2 into dmtrKovalenko:develop Feb 16, 2024
4 checks passed
dmtrKovalenko pushed a commit that referenced this pull request Feb 16, 2024
@alirezamirian @dmtrKovalenko
feat: add touchMoveDelay option to realSwipe (#621)
4786db2 
* chore(docs): fix a few typos and issues in realSwipe docs

* feat(realSwipe): add `touchMoveDelay` option

closes #620
dmtrKovalenko added a commit that referenced this pull request Jun 15, 2024
@amoshydra @dmtrKovalenko
@dependabot @RahulRaj97 @alirezamirian @nicklemmon
fix: default x y to 0 when not provided, accept 0 value (#642)
beb4749 
* chore(deps-dev): bump eslint-plugin-cypress from 2.14.0 to 2.15.1

Bumps [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress) from 2.14.0 to 2.15.1.
- [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases)
- [Commits](cypress-io/eslint-plugin-cypress@v2.14.0...v2.15.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps-dev): bump fs-extra from 11.1.1 to 11.2.0

Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 11.1.1 to 11.2.0.
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md)
- [Commits](jprichardson/node-fs-extra@11.1.1...11.2.0)

---
updated-dependencies:
- dependency-name: fs-extra
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: Trying to resolve issue with 404 on chrome driver installation (#633)

* docs: Update links and comments for realSwipe function (#630)

Co-authored-by: Rahul Raj <[email protected]>

* feat: add touchMoveDelay option to realSwipe (#621)

* chore(docs): fix a few typos and issues in realSwipe docs

* feat(realSwipe): add `touchMoveDelay` option

closes #620

* fix:  and  interfaces are consistently cased with other option interfaces (#612)

* chore(closes #243): Add README to the npm release tarball

* chore(deps-dev): bump typedoc from 0.24.8 to 0.25.8 (#629)

Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.24.8 to 0.25.8.
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](TypeStrong/typedoc@v0.24.8...v0.25.8)

---
updated-dependencies:
- dependency-name: typedoc
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump eslint from 8.48.0 to 8.56.0 (#605)

Bumps [eslint](https://github.com/eslint/eslint) from 8.48.0 to 8.56.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.48.0...v8.56.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump typedoc-plugin-markdown from 3.15.3 to 3.17.1 (#587)

Bumps [typedoc-plugin-markdown](https://github.com/tgreyuk/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 3.15.3 to 3.17.1.
- [Release notes](https://github.com/tgreyuk/typedoc-plugin-markdown/releases)
- [Changelog](https://github.com/tgreyuk/typedoc-plugin-markdown/blob/master/packages/typedoc-plugin-markdown/CHANGELOG.md)
- [Commits](https://github.com/tgreyuk/typedoc-plugin-markdown/commits/[email protected]/packages/typedoc-plugin-markdown)

---
updated-dependencies:
- dependency-name: typedoc-plugin-markdown
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: default x y to 0 when not provided, accept 0 value

* chore(ci): fix chrome driver issue

* chore(jsdoc): Fix the link to the real swipe docs (#634)

Co-authored-by: stevenlee <[email protected]>

* fix: default x y to 0 when not provided, accept 0 value

* chore(deps-dev): bump fs-extra from 11.1.1 to 11.2.0

Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 11.1.1 to 11.2.0.
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md)
- [Commits](jprichardson/node-fs-extra@11.1.1...11.2.0)

---
updated-dependencies:
- dependency-name: fs-extra
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps-dev): bump eslint from 8.48.0 to 8.56.0 (#605)

Bumps [eslint](https://github.com/eslint/eslint) from 8.48.0 to 8.56.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.48.0...v8.56.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump typedoc-plugin-markdown from 3.15.3 to 3.17.1 (#587)

Bumps [typedoc-plugin-markdown](https://github.com/tgreyuk/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 3.15.3 to 3.17.1.
- [Release notes](https://github.com/tgreyuk/typedoc-plugin-markdown/releases)
- [Changelog](https://github.com/tgreyuk/typedoc-plugin-markdown/blob/master/packages/typedoc-plugin-markdown/CHANGELOG.md)
- [Commits](https://github.com/tgreyuk/typedoc-plugin-markdown/commits/[email protected]/packages/typedoc-plugin-markdown)

---
updated-dependencies:
- dependency-name: typedoc-plugin-markdown
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(jsdoc): Fix the link to the real swipe docs (#634)

Co-authored-by: stevenlee <[email protected]>

* fix: default x y to 0 when not provided, accept 0 value

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Dmitriy Kovalenko <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rahul Raj <[email protected]>
Co-authored-by: Rahul Raj <[email protected]>
Co-authored-by: Alireza Mirian <[email protected]>
Co-authored-by: Nick Lemmon <[email protected]>
Co-authored-by: stevenlee <[email protected]>
@dmtrKovalenko
Copy link
Owner

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lkolapp lkolapp mentioned this pull request Sep 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmtrKovalenko dmtrKovalenko dmtrKovalenko approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: delay option in realSwipe
2 participants
@alirezamirian @dmtrKovalenko