Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prettier to dev dependencies #528

Closed
lucy-m opened this issue Aug 3, 2023 · 5 comments · Fixed by #529
Closed

Move prettier to dev dependencies #528

lucy-m opened this issue Aug 3, 2023 · 5 comments · Fixed by #529
Labels

Comments

@lucy-m
Copy link

lucy-m commented Aug 3, 2023

Hello,

Prettier was added to the project two weeks ago to enforce code formatting, but it has been added to the dependencies section of package.json. Prettier should be a dev dependency.

This may be breaking for users of this library who are using version 2.x of Prettier, as installing this library causes version 3.0 of prettier to be installed and used.

Can prettier please be moved to the dev dependencies section?

@dmtrKovalenko
Copy link
Owner

Oops that is an issue

@lucy-m
Copy link
Author

lucy-m commented Aug 3, 2023

Thanks for resolving this quickly

@dmtrKovalenko
Copy link
Owner

releasedd in 1.10

@dmtrKovalenko
Copy link
Owner

🎉 This issue has been resolved in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@joshwooding
Copy link
Contributor

Looks like prettier is still a dependency. I've raised #532 to remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants