Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not filter out the [PAD] tokens when computing loss? #174

Open
zdgithub opened this issue Mar 3, 2022 · 0 comments
Open

Why not filter out the [PAD] tokens when computing loss? #174

zdgithub opened this issue Mar 3, 2022 · 0 comments

Comments

@zdgithub
Copy link

zdgithub commented Mar 3, 2022

I found that the losses of the [PAD] tokens were also computed when training the model. But in fact, we should filter out them as https://github.com/kyzhouhzau/BERT-NER/blob/master/BERT_NER.py does. Why didn't you mask the losses of the [PAD] tokens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant