New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccuracy in the description of run() within AbstractInteractor #7

Open

ivan8m8 opened this issue May 28, 2018 · 0 comments

ivan8m8 commented May 28, 2018 •

edited

Loading

First of all thank you very much for your great work, @dmilicic.

I have been learning your sample app carefully and by now I've found a little inaccuracy in there.

Within domain/interactors/base/AbstractInteractor.java you mentioned that abstract run() is declared public for only easy testing. But actually if this method wasn't declared as a public, it would have been impossible to call it within domain/executor/impl/ThreadExecutor.java.

Hope, it makes sense for beginners, at least.

Regards,
Ivan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment