diff --git a/spring-integration-graphql/src/main/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandler.java b/spring-integration-graphql/src/main/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandler.java index f6cc7ddc9f3..7506f7e6d0c 100644 --- a/spring-integration-graphql/src/main/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandler.java +++ b/spring-integration-graphql/src/main/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandler.java @@ -80,14 +80,14 @@ public void setQueryExpression(Expression queryExpression) { * @param operationName the GraphQL Operation Name to use. */ public void setOperationName(String operationName) { - setOperationNameTypeExpression(new LiteralExpression(operationName)); + setOperationNameExpression(new LiteralExpression(operationName)); } /** * Set a SpEL expression to evaluate a GraphQL Operation Name to execute. * @param operationNameExpression the expression to use. */ - public void setOperationNameTypeExpression(Expression operationNameExpression) { + public void setOperationNameExpression(Expression operationNameExpression) { Assert.notNull(operationNameExpression, "'operationNameExpression' must not be null"); this.operationNameExpression = operationNameExpression; } @@ -129,20 +129,18 @@ else if (requestMessage.getPayload() instanceof String && !Strings.isNullOrEmpty } } - String evaluateQueryExpression(Message message) { + private String evaluateQueryExpression(Message message) { String query = this.queryExpression.getValue(this.evaluationContext, message, String.class); Assert.notNull(query, "'queryExpression' must not evaluate to null"); return query; } - String evaluateOperationNameExpression(Message message) { - Assert.notNull(this.operationNameExpression, "'operationNameExpression' must not be null when 'query' mode is used"); + private String evaluateOperationNameExpression(Message message) { return this.operationNameExpression.getValue(this.evaluationContext, message, String.class); } @SuppressWarnings("unchecked") - Map evaluateVariablesExpression(Message message) { - Assert.notNull(this.variablesExpression, "'variablesExpression' must not be null when 'query' mode is used"); + private Map evaluateVariablesExpression(Message message) { return this.variablesExpression.getValue(this.evaluationContext, message, Map.class); } diff --git a/spring-integration-graphql/src/test/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandlerTests.java b/spring-integration-graphql/src/test/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandlerTests.java index 0ac1eae12fa..c3859c610c4 100644 --- a/spring-integration-graphql/src/test/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandlerTests.java +++ b/spring-integration-graphql/src/test/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandlerTests.java @@ -313,10 +313,6 @@ void testHandleMessageForSubscriptionWithInvalidPayload() { } - private static T waitFor(Mono mono) { - return mono.block(Duration.ofSeconds(10)); - } - @Controller static class GraphQlController {