This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Refactored RateLimitCache to work on a per second basis, rather than per minute #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't just have an interval parameter. You have an implicit n=1: this needs to be explicit and modifiable. At least in theory, the pushshift server has the ability to adjust throttling up or down. Rate limit state is supposed to be reported out to clients via the /meta endpoint. Sounds like the throttling system has been changed without corresponding updates to this endpoint. Further discussion in issue #80. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adheres to the current Pushshift API rate-limit of 1 request per second.
https://pypi.org/project/pushshift.py