Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

sort and sort_type have been renamed in the API, breaking pagination #108

Open
aaronsnoswell opened this issue Feb 17, 2023 · 0 comments · May be fixed by #109
Open

sort and sort_type have been renamed in the API, breaking pagination #108

aaronsnoswell opened this issue Feb 17, 2023 · 0 comments · May be fixed by #109

Comments

@aaronsnoswell
Copy link

Hello!

I have been trying to get psaw working today and discovered that the sort and sort_type query fields have been renamed.

According to a comment on the r/Pushshift subreddit;

  • sort is now called order, and
  • sort_type is now called sort

This breaks the psaw library as sort=desc (which is appended to queries with no sort field) now triggers an HTTP 442 error, and specifying sort=None breaks pagination.

I've modded my local install of psaw to work, and will attempt to prepare a PR for the library.
aaronsnoswell added a commit to aaronsnoswell/psaw that referenced this issue Feb 17, 2023
@aaronsnoswell
Rename sort -> order
c40bd6e 
Fixes dmarx#108.
@aaronsnoswell aaronsnoswell linked a pull request Feb 17, 2023 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename sort -> order aaronsnoswell/psaw
1 participant
@aaronsnoswell