Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to Remove Games #27

Closed
SmellsNice opened this issue Aug 2, 2021 · 8 comments
Closed

[Feature Request] Ability to Remove Games #27

SmellsNice opened this issue Aug 2, 2021 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SmellsNice
Copy link

SmellsNice commented Aug 2, 2021

Currently (as far as I am aware) there is no way to remove downloaded games through steam-tui. It would be a nice addition and be really convenient.

PS: I think the aur package is a bit behind the repo so whoever maintains it might want to update it.

@dmadisetti
Copy link
Owner

Hmm, this makes sense but is also dangerous?

steamcmd does have a app_uninstall : <appId>, but casually hitting a button and uninstalling a game seems like a pain?
There's also no logging of the spawned threads, so no way of getting immediate feedback if an uninstall did occur (see #20).
The best way of doing this might be this might be running steam-tui with a flag, e.g. steam-tui --dangerous which would let you press x to uninstall a game.

I am also unsure whether an 'uninstall' removes files/saves/cache, or just purges whatever local database.

What were you thinking? Thoughts?

RE: PS: Yes it is. Cargo is also behind main (we now have auto-downloaded and cached images!), I'll sync everything up next big change I make.

@dmadisetti dmadisetti added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 2, 2021
@SmellsNice
Copy link
Author

Hmm, this makes sense but is also dangerous?

steamcmd does have a app_uninstall : <appId>, but casually hitting a button and uninstalling a game seems like a pain?
There's also no logging of the spawned threads, so no way of getting immediate feedback if an uninstall did occur (see #20).
The best way of doing this might be this might be running steam-tui with a flag, e.g. steam-tui --dangerous which would let you press x to uninstall a game.

I am also unsure whether an 'uninstall' removes files/saves/cache, or just purges whatever local database.

What were you thinking? Thoughts?

RE: PS: Yes it is. Cargo is also behind main (we now have auto-downloaded and cached images!), I'll sync everything up next big change I make.

I can see how just pressing a button to delete every file might be dangerous. A confirm prompt or as you said a flag to start a "dangerous" mode might be the best option.I think steamcmd just removes every folder it creates for a game but I might have to test it out. Also steamcmd has a forceinstalldir function which might be simple to implement into steam-tui if you are interested.

@dmadisetti
Copy link
Owner

I think "dangerous" is the easiest work around for now. We can always make this default in the config later and add in a confirmation prompt. I might have some time later this week to test and try out app_uninstall

Yep! I am aware of the forceinstalldir. If not default, the steam directory has to be properly set as well (see #7)

@oati
Copy link

oati commented Jul 10, 2022

How does steam-tui handle install progress right now?

@dmadisetti
Copy link
Owner

Shows that's it's downloading, and will show when it's done. It should show a % for install too, but I haven't seen it yet....

Relevant code:

match *INSTALL_LEX.tokenize(&response).as_slice() {

@txrunn
Copy link

txrunn commented Feb 4, 2023

Hey, I was wondering if I could pick up this issue. It would be my first open source contribution, I would also appreciate any help with getting started.

@dmadisetti
Copy link
Owner

So you can hide games now. I think to remove games we'd still want a yes/no prompt.

So steps would be,

  • Add keybinding to pick up delete key, and put into a confirmation mode
  • Add keybinding for yes, no on confirmation mode
  • Run a app uninstall script

At least for a first pass

@dmadisetti
Copy link
Owner

There's H to hide games, but I'm going to mark this as won't fix (unless someone adds it), cause I don't want to accidently delete my games

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants