Implement Spacer And Add keyboard support to StripView #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leewyatt
commented
Aug 21, 2023
•
leewyatt
commented
- Introducing Spacer Component for Dynamic Growth Direction in HBox and VBox #79
- Add keyboard support to StripView #63
leewyatt
changed the title
dlemmermann
requested changes
Aug 21, 2023
| @@ -232,6 +232,24 @@ public void scrollTo(T item) { | |||
| getProperties().put("scroll.to", item); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
The java docs have to be added to the property() method, in this case loopSelectionProperty().
| // If it's the last item and loop selection is off, don't consume the event | ||
| // so that focus can move to the next focusable component. | ||
| // Otherwise, select the next item. | ||
| if (index != itemCount - 1 || getSkinnable().isLoopSelection()) { |
There was a problem hiding this comment.
I would prefer the expression index < itemCount
| case RIGHT: | ||
| case ENTER: | ||
| // Check if loop selection is enabled or if we haven't reached the last item yet | ||
| if (getSkinnable().isLoopSelection() || index < itemCount - 1) { |
There was a problem hiding this comment.
Replace all getSkinnable() calls in this method with a previously assigned variable please.
dlemmermann
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.