Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reusability of DayEntryViewSkin #9

Closed
imario42 opened this issue Oct 22, 2017 · 2 comments
Closed

Reusability of DayEntryViewSkin #9

imario42 opened this issue Oct 22, 2017 · 2 comments

Comments

@imario42
Copy link
Contributor

Dirk, in DayEntryViewSkin, are you fine if I change the methods private modifier to protected so we are able to easily reuse and enhance it outside of the CalendarFX?
@dlemmermann
Copy link
Collaborator

Yes, fine with me. But then also please add javadocs.

@dlemmermann dlemmermann changed the title reusability of DayEntryViewSkin Reusability of DayEntryViewSkin Oct 22, 2017
@imario42
Copy link
Contributor Author

Committed. I've also introduced a new method setupUpdateListeners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imario42 @dlemmermann