Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt iCal4j recurrence #50

Closed
mkroening opened this issue Jul 19, 2019 · 2 comments
Closed

Adapt iCal4j recurrence #50

mkroening opened this issue Jul 19, 2019 · 2 comments

Comments

@mkroening
Copy link
Contributor

I was starting a follow up on #49 to remove any Joda-Time dependency from this project, as "from Java SE 8 onwards, users are asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces this project" (Joda-Time Home) and this library targets "JavaFX 8, 9, 10, and 11".

When looking at CalendarFXRecurrence, I wondered if the whole module could be replaced by the recurrence API of iCal4j. iCal4j implements RFC5545 (Supersedes RFC2445). It is already in the dependency tree as dependency of CalendarFXiCal and will adapt java.time (JSR-310) in the future (see ical4j/ical4j#242).

What do you think about that?

@dlemmermann
Copy link
Collaborator

That sounds like a very good idea. However I am not sure how big the impact will be on the public API of CalendarFX. If it is also possible to express the entire recurrence via a single string ("rrule" on Entry) then this would be great.

@mkroening
Copy link
Contributor Author

Resolved by #51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants