Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next release — 2.0.0? #53

Closed
danschmidt5189 opened this issue Feb 14, 2019 · 2 comments
Closed

Next release — 2.0.0? #53

danschmidt5189 opened this issue Feb 14, 2019 · 2 comments
Assignees
@vjt
Labels
rfc Request for comment

Comments

@danschmidt5189
Copy link
Collaborator

After merging #51 it's time to bump the release. That fix passes an additional argument to the fetch_raw_info callback, which breaks anyone using a Lambda. The README suggested using a lambda prior to that (I amended it to use a bare Proc), so I think it's reasonable for users to see this as a breaking change, implying a major version bump from the current v1.1.1 to a new v2.0.0.

Questions / comments / thoughts / concerns?
@danschmidt5189 danschmidt5189 added the rfc Request for comment label Feb 14, 2019
@vjt
Copy link
Collaborator

vjt commented Feb 14, 2019

Agree.

@jking916 jking916 mentioned this issue Nov 12, 2020
Merged
@vjt vjt self-assigned this Nov 12, 2020
@vjt
Copy link
Collaborator

vjt commented Nov 14, 2020

v2.0.0 has been pushed to Ruby Gems today 2020-11-14.

Cheers!

@vjt vjt closed this as completed Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vjt vjt

Labels
rfc Request for comment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vjt @danschmidt5189