From e21c0be55da2133eb37c251ef7e608fbb3fd32ae Mon Sep 17 00:00:00 2001
From: Derek Ho <dxho@amazon.com>
Date: Fri, 23 Feb 2024 07:10:22 -0500
Subject: [PATCH] Use GHA `derek-ho/start-opensearch` for OpenSearch plugin
 install tests (#4063)

Signed-off-by: Derek Ho <dxho@amazon.com>
---
 .../action.yml                                | 127 ------------------
 .github/workflows/plugin_install.yml          |  21 +--
 2 files changed, 3 insertions(+), 145 deletions(-)
 delete mode 100644 .github/actions/start-opensearch-with-one-plugin/action.yml

diff --git a/.github/actions/start-opensearch-with-one-plugin/action.yml b/.github/actions/start-opensearch-with-one-plugin/action.yml
deleted file mode 100644
index e8e0f4eb77..0000000000
--- a/.github/actions/start-opensearch-with-one-plugin/action.yml
+++ /dev/null
@@ -1,127 +0,0 @@
-name: 'Launch OpenSearch with a single plugin installed'
-description: 'Downloads latest build of OpenSearch, installs a plugin, executes a script and then starts OpenSearch on localhost:9200'
-
-inputs:
-  opensearch-version:
-    description: 'The version of OpenSearch that should be used, e.g "3.0.0"'
-    required: true
-
-  plugin-name:
-    description: 'The name of the plugin to use, such as opensearch-security'
-    required: true
-
-  setup-script-name:
-    description: 'The name of the setup script you want to run i.e. "setup" (do not include file extension). Leave empty to indicate one should not be run.'
-    required: false
-
-  admin-password:
-    description: 'The admin password uses for the cluster'
-    required: true
-
-runs:
-  using: "composite"
-  steps:
-
-    # Configure longpath names if on Windows
-    - name: Enable Longpaths if on Windows
-      if: ${{ runner.os == 'Windows' }}
-      run: git config --system core.longpaths true
-      shell: pwsh
-
-    # Download OpenSearch
-    - name: Download OpenSearch for Windows
-      uses: peternied/download-file@v2
-      if: ${{ runner.os == 'Windows' }}
-      with:
-        url: https://artifacts.opensearch.org/snapshots/core/opensearch/${{ inputs.opensearch-version }}-SNAPSHOT/opensearch-min-${{ inputs.opensearch-version }}-SNAPSHOT-windows-x64-latest.zip
-
-
-    - name: Download OpenSearch for Linux
-      uses: peternied/download-file@v2
-      if: ${{ runner.os == 'Linux' }}
-      with:
-        url: https://artifacts.opensearch.org/snapshots/core/opensearch/${{ inputs.opensearch-version }}-SNAPSHOT/opensearch-min-${{ inputs.opensearch-version }}-SNAPSHOT-linux-x64-latest.tar.gz
-
-    # Extract downloaded zip
-    - name: Extract downloaded tar
-      if: ${{ runner.os == 'Linux' }}
-      run: |
-        tar -xzf opensearch-*.tar.gz
-        rm -f opensearch-*.tar.gz
-      shell: bash
-
-    - name: Extract downloaded zip
-      if: ${{ runner.os == 'Windows' }}
-      run: |
-        tar -xzf opensearch-min-${{ inputs.opensearch-version }}-SNAPSHOT-windows-x64-latest.zip
-        del opensearch-min-${{ inputs.opensearch-version }}-SNAPSHOT-windows-x64-latest.zip
-      shell: pwsh
-
-    # Install the plugin
-    - name: Install Plugin into OpenSearch for Linux
-      if: ${{ runner.os == 'Linux'}}
-      run: |
-        chmod +x ./opensearch-${{ inputs.opensearch-version }}-SNAPSHOT/bin/opensearch-plugin
-        /bin/bash -c "yes | ./opensearch-${{ inputs.opensearch-version }}-SNAPSHOT/bin/opensearch-plugin install file:$(pwd)/opensearch-security.zip"
-      shell: bash
-
-    - name: Install Plugin into OpenSearch for Windows
-      if: ${{ runner.os == 'Windows'}}
-      run: |
-        'y' | .\opensearch-${{ inputs.opensearch-version }}-SNAPSHOT\bin\opensearch-plugin.bat install file:$(pwd)\${{ inputs.plugin-name }}.zip
-      shell: pwsh
-
-    # Run any configuration scripts
-    - name: Run Setup Script for Linux
-      if: ${{ runner.os == 'Linux' && inputs.setup-script-name != '' }}
-      run: |
-        echo "running linux setup"
-        export OPENSEARCH_INITIAL_ADMIN_PASSWORD=${{ inputs.admin-password }}
-        chmod +x ./${{ inputs.setup-script-name }}.sh
-        ./${{ inputs.setup-script-name }}.sh
-      shell: bash
-
-    - name: Run Setup Script for Windows
-      if: ${{ runner.os == 'Windows' && inputs.setup-script-name != '' }}
-      run: |
-        echo "running windows setup"
-        $env:OPENSEARCH_INITIAL_ADMIN_PASSWORD="${{ inputs.admin-password }}"
-        .\${{ inputs.setup-script-name }}.bat
-      shell: pwsh
-
-    # Run OpenSearch
-    - name: Run OpenSearch with plugin on Linux
-      if: ${{ runner.os == 'Linux'}}
-      run: /bin/bash -c "./opensearch-${{ inputs.opensearch-version }}-SNAPSHOT/bin/opensearch &"
-      shell: bash
-
-    - name: Run OpenSearch with plugin on Windows
-      if: ${{ runner.os == 'Windows'}}
-      run: start .\opensearch-${{ inputs.opensearch-version }}-SNAPSHOT\bin\opensearch.bat
-      shell: pwsh
-
-    # Give the OpenSearch process some time to boot up before sending any requires, might need to increase the default time!
-    - name: Sleep while OpenSearch starts
-      uses: peternied/action-sleep@v1
-      with:
-        seconds: 30
-
-    # Verify that the server is operational
-    - name: Check OpenSearch Running on Linux
-      if: ${{ runner.os != 'Windows'}}
-      run: curl https://localhost:9200/_cat/plugins -u 'admin:${{ inputs.admin-password }}' -k -v --fail-with-body
-      shell: bash
-
-    - name: Check OpenSearch Running on Windows
-      if: ${{ runner.os == 'Windows'}}
-      run: |
-        $credentialBytes = [Text.Encoding]::ASCII.GetBytes("admin:${{ inputs.admin-password }}")
-        $encodedCredentials = [Convert]::ToBase64String($credentialBytes)
-        $baseCredentials = "Basic $encodedCredentials"
-        $Headers = @{ Authorization = $baseCredentials }
-        Invoke-WebRequest -SkipCertificateCheck -Uri 'https://localhost:9200/_cat/plugins' -Headers $Headers;
-      shell: pwsh
-
-    - if: always()
-      run: cat ./opensearch-${{ inputs.opensearch-version }}-SNAPSHOT/logs/opensearch.log
-      shell: bash
diff --git a/.github/workflows/plugin_install.yml b/.github/workflows/plugin_install.yml
index b88cfb166f..fb86b915e0 100644
--- a/.github/workflows/plugin_install.yml
+++ b/.github/workflows/plugin_install.yml
@@ -39,27 +39,12 @@ jobs:
         run: mv ./build/distributions/${{ env.PLUGIN_NAME }}-*.zip ${{ env.PLUGIN_NAME }}.zip
         shell: bash
 
-      - name: Create Setup Script
-        if: ${{ runner.os == 'Linux' }}
-        run: |
-          cat > setup.sh <<'EOF'
-          chmod +x  ./opensearch-${{ env.OPENSEARCH_VERSION }}-SNAPSHOT/plugins/${{ env.PLUGIN_NAME }}/tools/install_demo_configuration.sh
-          /bin/bash -c "yes | ./opensearch-${{ env.OPENSEARCH_VERSION }}-SNAPSHOT/plugins/${{ env.PLUGIN_NAME }}/tools/install_demo_configuration.sh -t"
-          EOF
-
-      - name: Create Setup Script
-        if: ${{ runner.os == 'Windows' }}
-        run: |
-          New-Item .\setup.bat -type file
-          Set-Content .\setup.bat -Value "powershell.exe .\opensearch-${{ env.OPENSEARCH_VERSION }}-SNAPSHOT\plugins\${{ env.PLUGIN_NAME }}\tools\install_demo_configuration.bat -i -c -y -t"
-          Get-Content .\setup.bat
-
       - name: Run Opensearch with A Single Plugin
-        uses: ./.github/actions/start-opensearch-with-one-plugin
+        uses: derek-ho/start-opensearch@v2
         with:
           opensearch-version: ${{ env.OPENSEARCH_VERSION }}
-          plugin-name: ${{ env.PLUGIN_NAME }}
-          setup-script-name: setup
+          plugins: "file:$(pwd)/${{ env.PLUGIN_NAME }}.zip"
+          security-enabled: true
           admin-password: ${{ steps.random-password.outputs.generated_name }}
 
       - name: Run sanity tests