Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove posix only unittest relying on presence of unzip untility. #7196

Merged
merged 1 commit into from Sep 26, 2019
Merged

Remove posix only unittest relying on presence of unzip untility. #7196

merged 1 commit into from Sep 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 25, 2019

Even on posix systems you cannot rely on unzip being installed. In such cases, the unittest will fail, but should not fail.

@ghost ghost requested a review from CyberShadow as a code owner September 25, 2019 13:36
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @crocopaw! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7196"

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see this as a good idea. The test suite of most software is going to have special requirements on the host it runs on. We definitely shouldn't remove tests just because there exist systems out there that cannot run them.

@atilaneves
Copy link
Contributor

At most, this should be not run on systems that can't, but definitely not deleted.

@ghost ghost requested a review from CyberShadow September 26, 2019 08:40
std/zip.d Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Sep 26, 2019

I still feel unhealthy with this, but I believe you, that it is ok. I added the check proposed by cybershadow though.

@dlang-bot dlang-bot merged commit 25f38e4 into dlang:master Sep 26, 2019
ibuclaw added a commit that referenced this pull request May 17, 2020
[dmd-cxx] Backport fixes from #6752 and #7196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants