Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20145 - Random unittest failures in std.datetime.stopwatch #7186

Merged
merged 1 commit into from Sep 19, 2019
Merged

Fix issue 20145 - Random unittest failures in std.datetime.stopwatch #7186

merged 1 commit into from Sep 19, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2019

Times on benchmarks are not generally comparable (think of the computer heavily swapping during the first benchmark while not doing so during the second). I removed three asserts, which cannot generally be asserted and replaced them with two asserts, which give weaker, but save upper bounds.

@ghost ghost requested a review from jmdavis as a code owner September 17, 2019 14:29
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @crocopaw! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20145 normal Random unittest failures inf std.datetime.stopwatch

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7186"

@dlang-bot dlang-bot merged commit eb35b3f into dlang:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants