Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array.d: replace Error with assert() #7183

Merged
merged 1 commit into from
Sep 13, 2019
Merged

array.d: replace Error with assert() #7183

merged 1 commit into from
Sep 13, 2019

Conversation

WalterBright
Copy link
Member

Doesn't make sense to use both Error and assert. Besides, should just use assert anyway.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7183"

@dlang-bot dlang-bot merged commit 897ff6e into dlang:master Sep 13, 2019
@WalterBright WalterBright deleted the arrayError branch September 13, 2019 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@JackStouffer JackStouffer Awaiting requested review from JackStouffer JackStouffer is a code owner

@wilzbach wilzbach Awaiting requested review from wilzbach wilzbach is a code owner

@PetarKirov PetarKirov Awaiting requested review from PetarKirov PetarKirov is a code owner

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WalterBright @dlang-bot @thewilsonator