std.format: Fix compilation with no autodecode #7138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @CyberShadow! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7138" |
thewilsonator
approved these changes
Aug 15, 2019
|
There's more instances of these; need to look at how to fix this with the least changes. |
This is a pedantic fix.
Narrower char types cannot fit the result of parsing an escaped character.
Parsing as the string element type (char, in non-autodecode mode) does not allow fitting the result of parsing escapes. Those always need to be parsed into a dchar.
CyberShadow
force-pushed
the
pull-20190815-111010
branch
from
1b1d124
to
e9c8d30
Compare
|
There is a runtime unittest failure remaining in std.format, but the lead goes into std.uni, so I suspect it's the same problem as with std.regex / std.net.curl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire instantiated template hierarchy there actually can't compile or work with a narrow char type, because at some point it wants to decode an escape, which will fit only in a
dcharanyway.For #7130