fix array(String) to work with no autodecode #7133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
requested review from
JackStouffer,
wilzbach and
PetarKirov
as code owners
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7133" |
| if (isNarrowString!String) | ||
| { | ||
| import std.utf : toUTF32; | ||
| auto temp = str.toUTF32; | ||
| /* Unsafe cast. Allowed because toUTF32 makes a new array | ||
| and copies all the elements. | ||
| */ | ||
| return () @trusted { return cast(ElementType!String[]) temp; } (); | ||
| return () @trusted { return cast(CopyTypeQualifiers!(ElementType!String, dchar)[]) temp; } (); |
There was a problem hiding this comment.
Make one of these auto. That is a horrible return type to spell out twice.
There was a problem hiding this comment.
Gah I meant typeof(return)
thewilsonator
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With autodecode turned off, the return value wasn't a
dchar[].First fix for #7130