Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find Phobos dependencies on autodecode #7130

Closed
wants to merge 1 commit into from

Conversation

WalterBright
Copy link
Member

@WalterBright WalterBright commented Aug 13, 2019

To get rid of autodecode, first we must make Phobos independent of whether autodecoding is on or off. So turn it off and see what breaks.

Fixes should be in separate PRs labelled with [no autodecode]. They should be one of:

  1. use https://dlang.org/phobos/std_utf.html#byChar
  2. use https://dlang.org/phobos/std_utf.html#byDchar
  3. hardcode decoding

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7130"

@thewilsonator
Copy link
Contributor

So turn it off and see what breaks.

This should eventually go under a version that we can set defaults on

@WalterBright
Copy link
Member Author

Added [no autodecode] label. Please add this to all PRs that fix autodecoding to work with no autodecoding.

@LightBender
Copy link
Contributor

PR closed as stalled. This can be resurrected for Phobos 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Rebase no autodecode Make Phobos work without autodecoding stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants