-
-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std.process: add missing check for failed malloc() #7116
Conversation
fb9072d
to
adf9dab
Compare
Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7116" |
adf9dab
to
5f8d9e3
Compare
How can I retest buildkite? |
You need to be part of the Buildkite D team (otherwise there's only the old |
Thanks! |
Restarted it again as Baszile has removed his GitHub account and his packages are no longer available. |
Given that you found this bug in Phobos, their may be more lurking. Please grep and check all instances of |
5f8d9e3
to
9719e11
Compare
9719e11
to
3b0c616
Compare
@@ -98,6 +98,9 @@ version (Windows) | |||
import std.windows.syserror; | |||
} | |||
|
|||
import core.exception : OutOfMemoryError; | |||
|
|||
import std.exception : enforce; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, why were the local imports moved to a global import? I think that's opposite to current Phobos policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't care about, thank you for remind! Fixed at #7150
No description provided.