Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.process: add missing check for failed malloc() #7116

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Jul 28, 2019

No description provided.

@kubo39 kubo39 marked this pull request as ready for review July 28, 2019 05:40
std/process.d Outdated Show resolved Hide resolved
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7116"

std/process.d Outdated Show resolved Hide resolved
@kubo39
Copy link
Contributor Author

kubo39 commented Aug 9, 2019

How can I retest buildkite?

@wilzbach
Copy link
Member

wilzbach commented Aug 9, 2019

You need to be part of the Buildkite D team (otherwise there's only the old commit --amend trick). I just restarted it for you, but if you ping me on Slack with your email, I can add you to Buildkite. Of course, traditional mail instead of Slack works too.

@kubo39
Copy link
Contributor Author

kubo39 commented Aug 9, 2019

Thanks!

@wilzbach
Copy link
Member

Restarted it again as Baszile has removed his GitHub account and his packages are no longer available.

@WalterBright WalterBright changed the title Checks if malloc() failed std.process: add missing check for failed malloc() Aug 13, 2019
@WalterBright
Copy link
Member

Given that you found this bug in Phobos, their may be more lurking. Please grep and check all instances of malloc, calloc and realloc.

@dlang-bot dlang-bot merged commit c25c94b into dlang:master Aug 20, 2019
@@ -98,6 +98,9 @@ version (Windows)
import std.windows.syserror;
}

import core.exception : OutOfMemoryError;

import std.exception : enforce;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, why were the local imports moved to a global import? I think that's opposite to current Phobos policy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't care about, thank you for remind! Fixed at #7150

@kubo39 kubo39 deleted the check-malloc-failed branch March 5, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants