Fix enum type in std.socket to match the receiver type #7094
Conversation
|
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7094" |
| @@ -729,7 +729,7 @@ public: | |||
| private void addPerCall(string f, uint n, names...)(ulong[] values...) | |||
| { | |||
| import std.array : join; | |||
| enum uint mask = mixin("Options."~[names].join("|Options.")); | |||
| enum ulong mask = mixin("Options."~[names].join("|Options.")); | |||
There was a problem hiding this comment.
Assigning ulong to uint.
There was a problem hiding this comment.
This is known at compile time, isn't it ? So it should not be a problem.
There was a problem hiding this comment.
The idea is that if the user has forced a type upon an enum, it should always be taken into account.
There was a problem hiding this comment.
That sounds like a very arbitrary limitation without apparent benefit.
| @@ -480,7 +480,7 @@ struct Task(alias fun, Args...) | |||
| static if (isFunctionPointer!(_args[0])) | |||
| { | |||
| private enum bool isPure = | |||
| functionAttributes!(Args[0]) & FunctionAttribute.pure_; | |||
| (functionAttributes!(Args[0]) & FunctionAttribute.pure_) != 0; | |||
There was a problem hiding this comment.
Assigning uint to bool.
|
I had to fix 2 more cases. |
|
Wait this should target stable. |
|
It is ok to target master. dlang/dmd#10099 cannot target stable. |
This currently blocks [1]. The enum is declared as an integer, but it is assigned to ushort variables. This worked due to a bug in dmd which is now being fixed.
[1] dlang/dmd#10099