Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds asserts messages #7089

Merged

Conversation

burner
Copy link
Member

@burner burner commented Jun 25, 2019

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @burner!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7089"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

@burner burner force-pushed the std.algorithm.searching_assert_messages branch from c219e74 to 5d078e3 Compare June 25, 2019 10:19
@burner burner force-pushed the std.algorithm.searching_assert_messages branch from 5d078e3 to 31d5b84 Compare June 25, 2019 10:25
@burner
Copy link
Member Author

burner commented Jun 25, 2019

@thewilsonator I was a second to slow

std/algorithm/searching.d Outdated Show resolved Hide resolved
@burner
Copy link
Member Author

burner commented Jun 26, 2019

@thewilsonator could you have a look?

@thewilsonator
Copy link
Contributor

Done.

@burner
Copy link
Member Author

burner commented Jun 26, 2019

that was quick, how do you do it? thanks

@thewilsonator
Copy link
Contributor

magic

@burner
Copy link
Member Author

burner commented Jun 26, 2019

yeah, that is what I expected :-)

@thewilsonator
Copy link
Contributor

You know me too well.

@dlang-bot dlang-bot merged commit 9fb63a5 into dlang:master Jun 26, 2019
@burner
Copy link
Member Author

burner commented Jun 26, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants