Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant of an array can be compared with another array #7061

Merged

Conversation

Zevenberge
Copy link
Contributor

Fixes 11061

@Zevenberge Zevenberge requested a review from andralex as a code owner June 6, 2019 08:55
@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 6, 2019

Thanks for your pull request and interest in making D better, @Zevenberge! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
11061 normal std.variant.Variant equality comparison always returns false for static array literals.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7061"

@Zevenberge Zevenberge force-pushed the 11061-compare-static-and-dynamic-arrays branch from 85ad775 to ff06ef3 Compare June 6, 2019 08:59
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

std/variant.d Outdated Show resolved Hide resolved
@Zevenberge Zevenberge force-pushed the 11061-compare-static-and-dynamic-arrays branch from ff06ef3 to 613c0b1 Compare June 6, 2019 12:14
@thewilsonator thewilsonator added the 72h no objection -> merge The PR will be merged if there are no objections raised. label Jun 6, 2019
@thewilsonator thewilsonator added auto-merge and removed 72h no objection -> merge The PR will be merged if there are no objections raised. labels Jun 10, 2019
@dlang-bot dlang-bot merged commit fdbcaed into dlang:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants