assert messages for std.string #7034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @burner! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7034" |
burner
force-pushed
the
std.string_assert_messages
branch
from
8943eaf
to
d4c5212
Compare
burner
force-pushed
the
std.string_assert_messages
branch
from
d4c5212
to
50b07b3
Compare
thewilsonator
approved these changes
May 24, 2019
thewilsonator
added
the
72h no objection -> merge
wilzbach
force-pushed
the
std.string_assert_messages
branch
from
50b07b3
to
a429019
Compare
|
CircleCi failure was due to the PR targetting an old master of Phobos. Rebasing against latest upstream/master helps (just did that for you). |
|
BTW we have a diff --git a/.dscanner.ini b/.dscanner.ini
index 4d33cde60..89f63d64c 100644
--- a/.dscanner.ini
+++ b/.dscanner.ini
@@ -196,7 +196,6 @@ assert_without_msg="-etc.c.SQL_,\
-std.signals,\
-std.socket,\
-std.stdio,\
--std.string,\
-std.traits,\
-std.typecons,\
-std.uni,\run with e.g. make -f posix.mak dscanner |
|
@wilzbach thank you |
starting to work on dlang/phobos/project/2
burner
force-pushed
the
std.string_assert_messages
branch
from
a429019
to
f3244d5
Compare
thewilsonator
added
auto-merge
and removed
72h no objection -> merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting to work on dlang/phobos/project/2