Revert "Decrease template instantiation in std.algorithm.searching : all & any" #6988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8sh
requested review from
andralex,
JackStouffer,
wilzbach and
PetarKirov
as code owners
|
Thanks for your pull request, @n8sh! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + phobos#6988" |
|
Can we add a test case that fails now, but will be fixed by the revert? |
n8sh
force-pushed
the
revert-6960-searchingAllAnyFewerTemplates
branch
from
a333041
to
08e49dd
Compare
|
@wilzbach added tests. |
|
@n8sh please rebase your branch onto |
|
@ZombineDev At the time this PR was submitted the bug didn't exist in stable. Time marched on. |
n8sh
force-pushed
the
revert-6960-searchingAllAnyFewerTemplates
branch
from
08e49dd
to
384320c
Compare
n8sh
force-pushed
the
revert-6960-searchingAllAnyFewerTemplates
branch
from
384320c
to
d410281
Compare
PetarKirov
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6960. Reason:
foreachdoes not auto-decodestring&wstring.