fix Issue 19777 - SortedRange.opSlice should infer safety #6984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unittests did fail with DIP1000 due to missing return scope inference in chained range, thus leading to a scope violation which prevented `@safe` inference - fixed unittests by adding return scope to chain.Result - would still fail under dip1000 with other ranges that miss return scope on their opSlice - should not have any effect on non-DIP1000 usage
MartinNowak
requested review from
andralex,
JackStouffer,
wilzbach and
PetarKirov
as code owners
|
Thanks for your pull request, @MartinNowak! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + phobos#6984" |
MartinNowak
added
the
stable-priority
|
Please ignore the dlang/druntime benchmark link failure in buildkite, this is due to an incorrect setup (the benchmark would import phobos stable but link against phobos head). |
thewilsonator
approved these changes
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inference in chained range, thus leading to a scope violation
which prevented
@safeinferencemiss return scope on their opSlice