Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitives: add scope #6570

Merged
merged 1 commit into from
May 9, 2019
Merged

Conversation

WalterBright
Copy link
Member

No description provided.

@WalterBright WalterBright added the Vision Vision Plan https://wiki.dlang.org/Vision/2018H1 label Jun 9, 2018
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6570"

@wilzbach
Copy link
Member

std/range/primitives.d(600): Error: `@safe` function `std.range.primitives.__unittest_L593_C7` cannot call `@system` function `std.range.primitives.put!(int[][], int[]).put`
std/range/primitives.d(610): Error: `@safe` function `std.range.primitives.__unittest_L605_C7` cannot call `@system` function `std.range.primitives.put!(int[][], int[]).put`

Maybe we should be a bit more careful with this one?

Copy link
Member

@n8sh n8sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is just replacing in with scope const inside some unit tests (and the two were at one point intended to by synonymous), if the tests were passing before this PR and are still passing after it I don't see a reason not to merge this.

@PetarKirov PetarKirov added auto-merge Trivial typos, formatting, comments labels May 6, 2019
@wilzbach
Copy link
Member

wilzbach commented May 9, 2019

rebased to master

@dlang-bot dlang-bot merged commit 1f70299 into dlang:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Trivial typos, formatting, comments Vision Vision Plan https://wiki.dlang.org/Vision/2018H1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants