Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dub's support for source libraries where the package root is the repository root is incomplete? #948

Closed
timotheecour opened this issue Sep 29, 2016 · 8 comments

Comments

@timotheecour
Copy link

cf: CyberShadow/Digger#38 (comment)
this is blocking Digger from being included in dub repository

@s-ludwig
Copy link
Member

Hm, they should work correctly since 0.9.25. The corresponding issue is #502.

@CyberShadow
Copy link
Member

Sorry for being so vague Sönke :) I remember running into an unexpected problem when I tried setting it up a while ago but the details escape me. Naturally I wouldn't file a bug without collecting the specifics, this has been on my backlog for a while.

Anyway, I can give it another go now if you can transfer ownership of http://code.dlang.org/packages/ae to me.

@s-ludwig
Copy link
Member

Before the transfer, can you pull @Paxa's current version to some branch in your original repository, as well as the v1.0.0 and v1.0.1 tags? Otherwise this would likely break some dependent code.

@CyberShadow
Copy link
Member

ae is definitely not at v1.0.0 (as far as SemVer is concerned) :/

I doubt there is going to be any code breakage, because that version doesn't compile with recent DMD versions any more (besides also that that fork is unofficial and unsupported).

@CyberShadow
Copy link
Member

Pushed the branches, though.

@s-ludwig
Copy link
Member

Fair enough, if it doesn't compile with current compiler versions. I've had a look at the downloads and the meta data has been downloaded 15 times in September (only counting downloads using the DUB CLI), so at least someone attempted to use it. But there are no public packages using it, so the impact should be small. I'll make the switch!

@s-ludwig
Copy link
Member

Okay, done now. You'll still have to change the GitHub repository from the package management page.

@CyberShadow
Copy link
Member

Thanks! Everything seems to work now. I don't remember what problems I had run into (or how I even concluded that they were there since I had no control over the ae repository), but they're evidently gone now.

http://code.dlang.org/packages/digger

I guess this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants