Fix duplicate compiler switches for nested dependencies. Fixes #686. #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Build type settings of dependencies used to accumulate in the dependent projects. This change now adds the build type settings only once after all targets have been collected.
s-ludwig
force-pushed
the
issue686-multiple-march
branch
from
20bda45 to
25d709b
Compare
s-ludwig
added a commit
that referenced
this pull request
Feb 17, 2016
…-march Fix duplicate compiler switches for nested dependencies. Fixes #686.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue at its root and completely avoids emitting duplicate build settings. This is in contrast to filtering out duplicate settings, which can cause further issues down the line, because it's generally not easy to decide which flags are redundant.