Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library extensions for LDC when using the MS linker. Fixes #618. #688

Merged
merged 2 commits into from
May 27, 2016

Conversation

s-ludwig
Copy link
Member

Fixes the output binary extensions for the MSVC version of LDC. This requires runtime detection of the type of compiler invoked and thus requires moving the target filename handling code to the compiler class.

@s-ludwig
Copy link
Member Author

s-ludwig commented Apr 1, 2016

This affects the public API and thus should be merged prior to 1.0.0.

@s-ludwig s-ludwig changed the title Fix issue 618 Fix library extensions for LDC when using the MS linker. Fixes #618. Apr 1, 2016
@s-ludwig
Copy link
Member Author

s-ludwig commented Apr 1, 2016

Should work now, but should be rebased on top of #785 before merge, because that makes some of the API changes in this PR obsolete.

@s-ludwig
Copy link
Member Author

s-ludwig commented Apr 1, 2016

Writing a specific test case is currently not possible, because this only affects the Windows versions of LDC.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 60.02% when pulling 9c2c118 on fix_issue_618 into efbff45 on master.

@p0nce
Copy link
Contributor

p0nce commented Apr 28, 2016

You can assume the MS linker is always used nowadays.

@s-ludwig
Copy link
Member Author

So it's not possible to build LDC with cygwin anymore?

@p0nce
Copy link
Contributor

p0nce commented Apr 29, 2016

You probably meant Cygwin? The last LDC release which built programs with the MinGW linker was 0.16.0 IIRC. This version has been bested by every LDC release since then on Windows, to the point I doubt anyone uses 0.16.0 anymore for this platform.

@s-ludwig
Copy link
Member Author

("meant Cygwin?" Did you mean MinGW? :P - but you are right, I didn't even know which one of the two was used) But independently of LDC on Windows, I think it probably is a good idea to move the logic to the compiler class anyway. It will become important again once cross compilation comes into play.

@p0nce
Copy link
Contributor

p0nce commented Apr 29, 2016

"meant Cygwin?" Did you mean MinGW?

Yes :-)

@s-ludwig
Copy link
Member Author

Anyone else with opinions on this change set?

@p0nce: Do you see any issues with pulling it like this? I'd like to keep the generally added flexibility and keeping support for a MinGW based LDC, even if rarely used, seems to be not the worst idea.

@p0nce
Copy link
Contributor

p0nce commented May 25, 2016

I see no issues in this. Was just signalling that MinGW is a minority case.

@s-ludwig s-ludwig merged commit 8f87d9f into master May 27, 2016
@s-ludwig s-ludwig deleted the fix_issue_618 branch June 15, 2016 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants