-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix library extensions for LDC when using the MS linker. Fixes #618. #688
Conversation
This affects the public API and thus should be merged prior to 1.0.0. |
Should work now, but should be rebased on top of #785 before merge, because that makes some of the API changes in this PR obsolete. |
Writing a specific test case is currently not possible, because this only affects the Windows versions of LDC. |
You can assume the MS linker is always used nowadays. |
So it's not possible to build LDC with cygwin anymore? |
You probably meant Cygwin? The last LDC release which built programs with the MinGW linker was 0.16.0 IIRC. This version has been bested by every LDC release since then on Windows, to the point I doubt anyone uses 0.16.0 anymore for this platform. |
("meant Cygwin?" Did you mean MinGW? :P - but you are right, I didn't even know which one of the two was used) But independently of LDC on Windows, I think it probably is a good idea to move the logic to the compiler class anyway. It will become important again once cross compilation comes into play. |
Yes :-) |
Anyone else with opinions on this change set? @p0nce: Do you see any issues with pulling it like this? I'd like to keep the generally added flexibility and keeping support for a MinGW based LDC, even if rarely used, seems to be not the worst idea. |
I see no issues in this. Was just signalling that MinGW is a minority case. |
Fixes the output binary extensions for the MSVC version of LDC. This requires runtime detection of the type of compiler invoked and thus requires moving the target filename handling code to the compiler class.