-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send additional env vars to build commands. #593
Conversation
env["D_FRONTEND_VER"] = to!string(settings.platform.frontendVersion); | ||
|
||
env["DUB_PLATFORM"] = join(cast(string[])settings.platform.platform,"-"); | ||
env["DUB_ARCH"] = join(cast(string[])settings.platform.architecture,"-"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" "
might make more sense as a delimiter for these two. Otherwise it may be confusing because of its similarity to the platform suffix syntax (<platform>[-<arch>[-<compiler>]]
).
Can you do a quick rebase? Generally LGTM. |
"Sönke Ludwig" [email protected] wrote:
Sure, as soon as I get back to my pc, I'll do that and your other suggested change. Been awhile since I've needed to rebase a PR, and I'm not exactly a git expert, can you remind me how to do that? I seem to remember it being something really simple. |
Ok, rebased. |
Thanks, merging in! Probably the easiest way to keep a branch rebased on top of another one is to use |
Send additional env vars to build commands.
Some of these (especially
DC
,DUB_CONFIG
,DUB_BUILD_TYPE
,DUB_PACKAGE_DIR
, andDUB_RUN
) can be quite useful.