Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send additional env vars to build commands. #593

Merged
merged 2 commits into from
Jul 1, 2015

Conversation

Abscissa
Copy link
Contributor

Some of these (especially DC, DUB_CONFIG, DUB_BUILD_TYPE, DUB_PACKAGE_DIR, and DUB_RUN) can be quite useful.

env["D_FRONTEND_VER"] = to!string(settings.platform.frontendVersion);

env["DUB_PLATFORM"] = join(cast(string[])settings.platform.platform,"-");
env["DUB_ARCH"] = join(cast(string[])settings.platform.architecture,"-");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" " might make more sense as a delimiter for these two. Otherwise it may be confusing because of its similarity to the platform suffix syntax (<platform>[-<arch>[-<compiler>]]).

@s-ludwig
Copy link
Member

Can you do a quick rebase? Generally LGTM.

@Abscissa
Copy link
Contributor Author

"Sönke Ludwig" [email protected] wrote:

Can you do a quick rebase? Generally LGTM.

Sure, as soon as I get back to my pc, I'll do that and your other suggested change.

Been awhile since I've needed to rebase a PR, and I'm not exactly a git expert, can you remind me how to do that? I seem to remember it being something really simple.

@Abscissa
Copy link
Contributor Author

Abscissa commented Jul 1, 2015

Ok, rebased.

@s-ludwig
Copy link
Member

s-ludwig commented Jul 1, 2015

Thanks, merging in!

Probably the easiest way to keep a branch rebased on top of another one is to use git pull --rebase [<remote> [<branch>]]. But I almost always use TortoiseGIT for such things. It has a convenient interactive rebase dialog (use "Fetch..." and choose the "Launch Rebase After Fetch" option), where you can see all relevant information at once, instead of having to juggle with git status, git diff, git add, git checkout and all those other commands.

s-ludwig added a commit that referenced this pull request Jul 1, 2015
Send additional env vars to build commands.
@s-ludwig s-ludwig merged commit d39552b into dlang:master Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants