fix Issue 19551 - corrupt ELF library when using pragma(crt_constructor) #9204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seg_data reused without being reset, this could cause arbitrary cross-talk. In this case, SDassocseg caused data to be written into an unrelated segment
|
Thanks for your pull request, @rainers! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#9204" |
thewilsonator
approved these changes
Jan 5, 2019
|
How new is this, i.e. should this target stable? |
Yes every non-controversial bug fix should target stable. https://wiki.dlang.org/DIP75#Branching_strategy
|
|
Well that solves that problem. |
|
Yup and to get the fix back to master, everyone can run |
AFAICT from the history it is a regression in dmd 2.025 ;-) |
WalterBright
approved these changes
Jan 5, 2019
|
Wow! That is old! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seg_data reused without being reset, this could cause arbitrary cross-talk. In this case, SDassocseg caused data to be written into an unrelated segment