-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow initializing fields with themself #20696
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20696" |
Errors in buildkite projects: |
Errors in Phobos(!) dlang/phobos#10620 |
gotta love seein' returns for a good diagnostic right away, eh? |
Fix self assignment for dlang/dmd#20696
Fixed, thank you. |
08dddfb
to
2acf6b0
Compare
dagon was fxed by gecko0307/dagon#96 do we need a new tag for build kite to pick it up or do we just need to rerun CI? |
Trying to prevent a common user error: Super easy struct construction question that I'm embarrassed to ask.
This might need a deprecation, but let's try errors first to see how buildkite responds.