Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow initializing fields with themself #20696

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jan 13, 2025

Trying to prevent a common user error: Super easy struct construction question that I'm embarrassed to ask.

This might need a deprecation, but let's try errors first to see how buildkite responds.

@dkorpel dkorpel added the Review:Needs Changelog A changelog entry needs to be added to /changelog label Jan 13, 2025
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20696"

thewilsonator added a commit to dlang/phobos that referenced this pull request Jan 13, 2025
@thewilsonator
Copy link
Contributor

Errors in Phobos(!) dlang/phobos#10620

@Herringway
Copy link
Contributor

gotta love seein' returns for a good diagnostic right away, eh?

dkorpel added a commit to dlang/phobos that referenced this pull request Jan 14, 2025
@CyberShadow
Copy link
Member

Fixed, thank you.

dkorpel added a commit to dkorpel/dagon that referenced this pull request Jan 14, 2025
dkorpel added a commit to dkorpel/swarm that referenced this pull request Jan 14, 2025
Geod24 pushed a commit to sociomantic-tsunami/swarm that referenced this pull request Jan 14, 2025
@dkorpel dkorpel force-pushed the ctor-self-assignment branch from 08dddfb to 2acf6b0 Compare January 14, 2025 17:52
@dkorpel dkorpel removed the Review:Needs Changelog A changelog entry needs to be added to /changelog label Jan 14, 2025
@thewilsonator
Copy link
Contributor

dagon was fxed by gecko0307/dagon#96 do we need a new tag for build kite to pick it up or do we just need to rerun CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants