Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image autocleaner #47

Merged
merged 17 commits into from
Sep 27, 2020
Merged

Add image autocleaner #47

merged 17 commits into from
Sep 27, 2020

Conversation

lebedevilya
Copy link
Contributor

This option is created in order to clean old images after update

@djmaze
Copy link
Collaborator

djmaze commented Sep 23, 2020

Looks good to me! Although personally I'd rather just use docker system prune.

It would be good to have an explaining sentence in the README, like for the other options. Can you add that? Otherwise I will do it.

Also, I will probably squash your commits into one.

@lebedevilya
Copy link
Contributor Author

Looks good to me! Although personally I'd rather just use docker system prune.

It would be good to have an explaining sentence in the README, like for the other options. Can you add that? Otherwise I will do it.

Also, I will probably squash your commits into one.

Good day! I added explanation to README; squashing commits seems like a good idea. About docker system prune - at first we decided to go that way, but we found that unsafe because you might unintentionally delete something you wanted to keep. This script ensure you clean only images of this exact service, which was updated, and no others will be affected.

@djmaze djmaze merged commit 4abe0a0 into containrrr:master Sep 27, 2020
@djmaze
Copy link
Collaborator

djmaze commented Sep 27, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants