Do not kill services if image download fails #34
Conversation
shepherd
Outdated
| @@ -23,18 +23,22 @@ update_services() { | |||
| image_with_digest="$(docker service inspect "$name" -f '{{.Spec.TaskTemplate.ContainerSpec.Image}}')" | |||
| image=$(echo "$image_with_digest" | cut -d@ -f1) | |||
| echo "Trying to update service $name with image $image" | |||
| docker service update "$name" $detach_option $registry_auth --image="$image" > /dev/null | |||
| docker pull $image && docker service update "$name" $detach_option $registry_auth --image="$image" > /dev/null | |||
There was a problem hiding this comment.
Well, this means all images are pulled to the machine that shepherd is running on. Which means quite some bandwidth and storage overhead.
As docker manifest is now available, I am really curious to try this out instead: https://stackoverflow.com/a/56316948
Would you like to adjust your PR accordingly?
There was a problem hiding this comment.
Thanks for your quick response.
I going to read your link and will try to adjust my PR.
In the meantime, I have a question (maybe naive, sorry). Will not the images be pulled to the nodes anyway? I mean, the nodes need it to run, what am I missing?
There was a problem hiding this comment.
Will not the images be pulled to the nodes anyway? I mean, the nodes need it to run, what am I missing?
Each image will only be pulled to the node the corresponding service runs on. With your pull approach, all images end on the node which runs the shepherd service as well.
There was a problem hiding this comment.
Oh, I understand now, thanks!
andresmoschini
force-pushed
the
robustness
branch
from
57c8f9d
to
7a7f692
Compare
andresmoschini
force-pushed
the
robustness
branch
from
7a7f692
to
4edaef0
Compare
|
Thanks! |
Hi @djmaze!
You have done an amazing job with this tool. Thanks!
I had the same problem that @rmie, so I have applied the change that he suggest in #28, then I realized that it was breaking shepherd script execution, so I added an exit code validation.
Could you review my changes? It would be great having this fixed in the official image.