Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject seo translations to prevent IntegrityError. #52

Closed
wants to merge 1 commit into from

Conversation

vinnyrose
Copy link
Contributor

Fixes #47

@vdboor
Copy link
Contributor

vdboor commented Jan 14, 2015

This is an interesting approach to the problem, but I expect it won't work if you have multiple page models that inherit from HtmlPage (which I have).

Secondly, I'm considering to turn the derived models into proxy models too, as RedirectNode and FluentPage no longer have any relevant model fields of their own. Everything has moved into translatable fields, so those models only have the effect or selecting a subset of nodes, through an expensive join.

@vdboor
Copy link
Contributor

vdboor commented Jan 14, 2015

If django-parler has on_delete=models.CASCADE, this problem would also not exist. Do you think there are drawbacks to that solution?

@vinnyrose
Copy link
Contributor Author

I think 959211c is a fine workaround for this. Anything else will likely be fragile and have many edge cases.

@vinnyrose vinnyrose closed this Jan 14, 2015
@vinnyrose vinnyrose deleted the fix_47 branch February 18, 2015 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete flatpages in admin
2 participants