Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--raft-multiplier is ignored #694

Closed
andreygolev opened this issue Mar 5, 2020 · 2 comments · Fixed by #753
Closed

--raft-multiplier is ignored #694

andreygolev opened this issue Mar 5, 2020 · 2 comments · Fixed by #753
Labels

Comments

@andreygolev
Copy link
Contributor

Describe the bug
--raft-multiplier cmd line parameter is ignored, when specified both, in config or cmd parameters.
I tried to investigate this, but didn't have any luck to pinpoint where it happens.

After bad luck with investigation, I tried to hardcode the default value for RaftMultiplier to dkron/config.go and it works just fine.

@vcastellm
Copy link
Member

vcastellm commented Apr 10, 2020

@andreygolev Could it be this? https://github.com/distribworks/dkron/blob/master/dkron/agent.go#L245

Everything from the config seems in place.

@andreygolev
Copy link
Contributor Author

Yes, exactly :) Everything from code looks in place, but it simply not working by unknown reason :)
Of course I'm using the value in the range of 1 - 10.
Try to print value of RaftMultiplier to stdout, and you should see that it's the default one, despite you're setting option.
I noticed it, because I started to see check failover and times were same, despite a value I set in a Multiplier via command line.
But it works just fine If hardcode it into a code :) This is how it works today, still in our infra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants