Remove controller parameter from queries #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
added
enhancement
Server
Dashboard
This comment has been minimized.
This comment has been minimized.
dbutenhof
force-pushed
the
uncontrolled
branch
from
3e84a42 to
08bf357
Compare
dbutenhof
force-pushed
the
uncontrolled
branch
2 times, most recently
from
680db64 to
e1c65fa
Compare
dbutenhof
force-pushed
the
uncontrolled
branch
from
e1c65fa to
6c9a5fd
Compare
webbnh
requested changes
Jan 10, 2022
dbutenhof
force-pushed
the
uncontrolled
branch
from
0212ba6 to
80397ba
Compare
dbutenhof
force-pushed
the
uncontrolled
branch
from
80397ba to
1cc9dfe
Compare
webbnh
previously approved these changes
Jan 17, 2022
portante
requested changes
Jan 17, 2022
"controller" is becoming just a dataset metadata; perhaps useful to filter based on origin, but not essential. The new /datasets/list API is based on a SQL query of the Datasets table, supporting filtering by name (substring, e.g., "fio"), controller, start and end time range (which can be used together or independently for a "before" or "after"). The Dataset record now has both `created` and `uploaded` timestamps, where the latter is the old `created` (defaults to current time of `Dataset` commit) and the new `created` is read from the tarball `metadata.log` file. Dataset SQL uniqueness is defined now only by the dataset name.
Try to work around an inexplicable test tarball unpacking problem on Jenkins by re-packing my modified test-5.2.tar.xz inside a local container.
Mostly factoring out some comments that have become issues.
dbutenhof
force-pushed
the
uncontrolled
branch
from
1cc9dfe to
d9bb283
Compare
portante
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"controller" is becoming just a dataset metadata; perhaps useful to filter based on origin, but not essential. The new
/datasets/listAPI is based on a SQL query of theDatasetstable, supporting filtering by name (substring, e.g., "fio"), controller, start and end time range (which can be used together or independently for a "before" or "after").The
Datasetrecord now has bothcreatedanduploadedtimestamps, where the latter is the oldcreated(defaults to current time ofDatasetcommit) and the newcreatedis read from the tarballmetadata.logfile.Dataset SQL uniqueness is defined now only by the dataset name.