Fix the _method
function of Connection
class in the auth module.
#3253
Labels
Milestone
_method
function of Connection
class in the auth module.
#3253
It seems that any "loose" keywords here get bundled into request
params
, but I'm kinda surprised that nobody complained about howConnection._method
accepts**kwargs
and then uses that as one of several parameters to overwrite the local definition ofkwargs
as adict
of keyword parameters torequest
. Wow; that's twisted. Using a different name would have been better: it's really easy when skimming through to assume that the**kwargs
in the request call is the samekwargs
passed into_method
. Ah well; that's not really in scope for this PR.Originally posted by @dbutenhof in #3235 (comment)
The text was updated successfully, but these errors were encountered: