From 6bf71c5f1f82b2dafe47dea0d6d6da5d454b086c Mon Sep 17 00:00:00 2001 From: Nick Dokos Date: Wed, 7 Jun 2023 19:55:16 -0400 Subject: [PATCH] Add comments to the new fixture --- .../agent/cli/commands/tools/test_tools_list.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/lib/pbench/test/functional/agent/cli/commands/tools/test_tools_list.py b/lib/pbench/test/functional/agent/cli/commands/tools/test_tools_list.py index 57cf5022f3..2b7fbb07f1 100644 --- a/lib/pbench/test/functional/agent/cli/commands/tools/test_tools_list.py +++ b/lib/pbench/test/functional/agent/cli/commands/tools/test_tools_list.py @@ -262,21 +262,34 @@ def tools_on_multiple_hosts(self, pbench_run): # Issue #3434 @pytest.fixture def labels_on_multiple_hosts(self, pbench_run): + # This fixture is meant to be called after the previous one + # (tools_on_multiple_hosts). The previous one establishes a + # tool-like directory structure; this one just embellishes it + # with labels on some host entries. Think of it as an + # double for-loop, like the one above, only unrolled. + + # row 1 group = "default" + # column 1 host = "th1.example.com" label = pbench_run / f"tools-v1-{group}" / host / "__label__" label.write_text("foo") + # column 2 host = "th2.example.com" label = pbench_run / f"tools-v1-{group}" / host / "__label__" label.write_text("bar") + # row 2 group = "test" + + # column 1 host = "th1.example.com" label = pbench_run / f"tools-v1-{group}" / host / "__label__" label.write_text("bar") + # column 2 # th2 has no label # Issue #2346