Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Automatic Sync not adding comment post ID #115

Closed
wants to merge 1 commit into from
Closed

fix: Automatic Sync not adding comment post ID #115

wants to merge 1 commit into from

Conversation

rafaucau
Copy link
Contributor

@rafaucau rafaucau commented Jan 29, 2022 •
edited
Loading

Description

This PR fixes adding comment_post_ID when synchronizing comments.

disqus-wordpress-plugin/disqus/rest-api/class-disqus-rest-api.php

Line 751 in c3b5e92

$ident_parts = explode( ' ', $first_identifier, 2 );

I checked what $thread['identifiers'] returns and that code made no sense. That's why the synchronization wasn't working.

Motivation and Context

Fixes #41

How Has This Been Tested?

I uploaded the code changes to production and finally the sync started working. After a year!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • All new and existing tests passed.

@LITUATUI
Copy link

LITUATUI commented May 4, 2022

Is this patch working for anyone? I still can't sync comments.

@rafaucau
Copy link
Contributor Author

rafaucau commented May 4, 2022 •
edited
Loading

It doesn't work anymore ¯_(ツ)_/¯

@rafaucau rafaucau closed this Jan 11, 2024
@rafaucau
Copy link
Contributor Author

Looks like #127 fixed it. At least manual sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic Sync not adding comment post ID
2 participants
@rafaucau @LITUATUI